Skip to content

Conversation

@wdconinc
Copy link
Contributor

Briefly, what does this PR introduce?

This PR adds optix-dev to the cuda environment.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue: bring support for opticks closer to eic-shell)
  • Documentation update
  • Other: __

Copilot AI review requested due to automatic review settings November 27, 2025 21:31
@wdconinc wdconinc enabled auto-merge (squash) November 27, 2025 21:32
Copilot finished reviewing on behalf of wdconinc November 27, 2025 21:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the optix-dev package to the cuda spack environment, bringing support for opticks (NVIDIA OptiX-based optical photon simulation) closer to eic-shell. The change is appropriate for the cuda environment since OptiX is NVIDIA's ray tracing API that requires CUDA support.

  • Adds optix-dev package to the cuda environment's package list in alphabetical order

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wdconinc wdconinc requested review from rahmans1 and veprbl November 28, 2025 14:10
@wdconinc
Copy link
Contributor Author

Fails in eicweb benchmarks for unrelated reasons, https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/jobs/6867175.

@wdconinc wdconinc disabled auto-merge November 29, 2025 01:57
@wdconinc wdconinc merged commit 9661d32 into master Nov 29, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants