Skip to content

Conversation

@wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Nov 28, 2025

Briefly, what does this PR introduce?

This PR upgrades podio to v1.6, jana2 to v2.4.3, and juggler to v15.0.3.

Copilot AI review requested due to automatic review settings November 28, 2025 16:50
Copilot finished reviewing on behalf of wdconinc November 28, 2025 16:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the podio package from version 1.3 to 1.6 by cherry-picking four upstream Spack commits that add intermediate versions (1.4, 1.4.1, 1.5) and the target version 1.6, along with a conditional cxxstd=23 value support. The upgrade maintains existing configuration settings (cxxstd=20, +rntuple) and follows the repository's established pattern for package version updates.

Key changes:

  • Cherry-picked four Spack commits adding podio versions 1.4 through 1.6
  • Updated podio version requirement from @1.3 to @1.6
  • Preserved existing build configuration (cxxstd=20, +rntuple, run_tests)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
spack-packages.sh Added four cherry-pick commit hashes with descriptions for podio versions 1.4, 1.4.1, 1.5, 1.6, and cxxstd=23 support
spack-environment/packages.yaml Updated podio version requirement from @1.3 to @1.6 while maintaining existing variant settings

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings November 28, 2025 17:05
Copilot finished reviewing on behalf of wdconinc November 28, 2025 17:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings November 28, 2025 18:45
Copilot finished reviewing on behalf of wdconinc November 28, 2025 18:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wdconinc wdconinc changed the title chore: podio-1.6 chore: podio-1.6, jana2-2.4.3 Nov 28, 2025
@wdconinc wdconinc enabled auto-merge (squash) November 28, 2025 18:50
@wdconinc wdconinc mentioned this pull request Nov 28, 2025
1 task
Copilot AI review requested due to automatic review settings November 28, 2025 22:06
Copilot finished reviewing on behalf of wdconinc November 28, 2025 22:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wdconinc wdconinc changed the title chore: podio-1.6, jana2-2.4.3 chore: podio-1.6, jana2-2.4.3, juggler-15.0.3 Nov 28, 2025
Copilot AI review requested due to automatic review settings November 29, 2025 00:36
Copilot finished reviewing on behalf of wdconinc November 29, 2025 00:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings November 29, 2025 01:56
Copilot finished reviewing on behalf of wdconinc November 29, 2025 01:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings November 29, 2025 15:22
Copilot finished reviewing on behalf of wdconinc November 29, 2025 15:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings November 29, 2025 19:53
Copilot finished reviewing on behalf of wdconinc November 29, 2025 19:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wdconinc wdconinc merged commit d3975d4 into master Dec 1, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants