Skip to content

Revert "zdc_pi0: allow_fail"#306

Open
veprbl wants to merge 2 commits into
masterfrom
revert-276-pr/zdc_pi0_allow_fail
Open

Revert "zdc_pi0: allow_fail"#306
veprbl wants to merge 2 commits into
masterfrom
revert-276-pr/zdc_pi0_allow_fail

Conversation

@veprbl
Copy link
Copy Markdown
Member

@veprbl veprbl commented May 20, 2026

Reverts #276

Copilot AI review requested due to automatic review settings May 20, 2026 14:06
@veprbl veprbl enabled auto-merge (squash) May 20, 2026 14:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the prior change that allowed the zdc_pi0 benchmark and result-collection jobs to fail without failing the pipeline, restoring them to strict CI behavior.

Changes:

  • Removed allow_failure: true from bench:zdc_pi0.
  • Removed allow_failure: true from collect_results:zdc_pi0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants