Add configurable Low-Q2 Tagger layer offsets#1016
Merged
Conversation
for more information, see https://pre-commit.ci
…c/epic into Add-configurable-tagger-layer-offsets
veprbl
approved these changes
Dec 16, 2025
Member
veprbl
left a comment
veprbl
left a comment
There was a problem hiding this comment.
LGTM, could add a name with detector prefix in it and move to definitions.xml
Contributor
Author
It might have been better in the definitions.xml file as its now forcing @ruse-traveler to develop some recursive xml parsing and saving for testing AID2E optimization. |
Contributor
TBH this is a good exercise for honing my python skills 😆 |
Member
|
It should not matter which xml file is rewritten, you need to copy the whole tree of xml files anyway. |
veprbl
added a commit
that referenced
this pull request
Feb 14, 2026
### Briefly, what does this PR introduce? Allows the z position of the individual layers of the Low-Q2 tracker to be moved by parameter. ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No ### Does this PR change default behavior? No --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Allows the z position of the individual layers of the Low-Q2 tracker to be moved by parameter.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
No