Skip to content

Remove MRICH #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
veprbl merged 4 commits into from
Nov 13, 2025
Merged

Remove MRICH #982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6bf7b00
Remove MRICH
veprbl Nov 7, 2025
8e96213
also in .github
veprbl Nov 7, 2025
d4ac3b2
Merge branch 'main' into pr/rm_mrich
veprbl Nov 11, 2025
1d31292
Merge branch 'main' into pr/rm_mrich
veprbl Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/labeler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
- changed-files:
- any-glob-to-any-file:
- "compact/**/backward_*"
- "compact/**/mrich*"
- "compact/**/pfrich*"

"topic: barrel":
Expand Down Expand Up @@ -88,7 +87,6 @@
- "src/*RICH*"
- "src/*DIRC*"
- "src/*TOF*"
- "src/MRich*"

"topic: tracking":
- all:
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/linux-eic-shell.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,7 @@ jobs:
sed -i 's%\(<fiber\|<lens\)%<comment>\1%g; s%\(/fiber>\|/lens>\)%\1</comment>%g' \
${DETECTOR_PATH}/compact/ecal/bic_default.xml \
${DETECTOR_PATH}/compact/ecal/forward_scfi.xml \
${DETECTOR_PATH}/compact/far_forward/ZDC_Ecal_WSciFi.xml \
${DETECTOR_PATH}/compact/pid/mrich.xml
${DETECTOR_PATH}/compact/far_forward/ZDC_Ecal_WSciFi.xml
- uses: actions/upload-artifact@v5
with:
name: build-${{ matrix.CC }}-${{ matrix.release }}-fast-eic-shell
Expand Down
3 changes: 1 addition & 2 deletions compact/definitions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,6 @@ The unused IDs below are saved for future use.
- Unused IDs: 133-139

</documentation>
<constant name="MRICH_ID" value="130"/>
<constant name="BackwardRICH_ID" value="131"/>
<constant name="BackwardTOF_ID" value="132"/>

Expand Down Expand Up @@ -325,7 +324,7 @@ SubSystemNameFurtherDescriptor_quantity
Examples:
- TrackerBarrelInside_length
- EcalEndcapP_rmin
- MRichFresnelLens_thickness
- TOFEndcapLayer_thickness

### Naming Barrel and Endcaps

Expand Down
5 changes: 0 additions & 5 deletions compact/display.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,11 +179,6 @@
<vis name="DRICH_sensor_vis" ref="AnlBlue" showDaughters="true" visible="true" />
<vis name="DRICH_service_vis" ref="AnlGreen" showDaughters="true" visible="true" />

<vis name="MRICH_aerogel_vis" ref="AnlTeal" showDaughters="true" visible="true" />
<vis name="MRICH_frame_vis" ref="AnlGold" showDaughters="true" visible="true" />
<vis name="MRICH_lens_vis" ref="AnlGray" showDaughters="true" visible="true" />
<vis name="MRICH_mirror_vis" ref="AnlGray" showDaughters="true" visible="true" />

<vis name="RICHServiceVis" ref="AnlGray" showDaughters="true" visible="true" />

<comment>
Expand Down
5 changes: 0 additions & 5 deletions compact/display_detailed.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,11 +133,6 @@
<vis name="DRICH_mirror_vis" ref="AnlGray" showDaughters="true" visible="true" />
<vis name="DRICH_sensor_vis" ref="AnlGreen" showDaughters="true" visible="true" />

<vis name="MRICH_aerogel_vis" ref="AnlTeal" showDaughters="true" visible="true" />
<vis name="MRICH_frame_vis" ref="AnlGold" showDaughters="true" visible="true" />
<vis name="MRICH_lens_vis" ref="AnlGray" showDaughters="true" visible="true" />
<vis name="MRICH_mirror_vis" ref="AnlGray" showDaughters="true" visible="true" />

<vis name="RICHServiceVis" ref="AnlGray" showDaughters="true" visible="true" />

<comment>
Expand Down
5 changes: 0 additions & 5 deletions compact/display_geoviewer.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,11 +133,6 @@
<vis name="DRICH_mirror_vis" ref="AnlGray" showDaughters="true" visible="true" />
<vis name="DRICH_sensor_vis" ref="AnlGreen" showDaughters="true" visible="true" />

<vis name="MRICH_aerogel_vis" ref="AnlTeal" showDaughters="true" visible="true" />
<vis name="MRICH_frame_vis" ref="AnlGold" showDaughters="true" visible="true" />
<vis name="MRICH_lens_vis" ref="AnlGray" showDaughters="true" visible="true" />
<vis name="MRICH_mirror_vis" ref="AnlGray" showDaughters="true" visible="true" />

<vis name="RICHServiceVis" ref="AnlGray" showDaughters="true" visible="true" />

<comment>
Expand Down
30 changes: 0 additions & 30 deletions compact/optical_materials.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1008,36 +1008,6 @@
<property name="REFLECTIVITY" ref="REFLECTIVITY_DIRC_mirror"/>
</opticalsurface>

<opticalsurface finish="polished" model="unified" name="MRICH_MirrorOpticalSurface" type="dielectric_metal" value="0">
</opticalsurface>
<opticalsurface finish="polished" model="unified" name="MRICH_LensOpticalSurface" type="dielectric_dielectric" value="0">
<property name="REFLECTIVITY" coldim="2" values="1240*eV/1100 0.08 1240*eV/400 0.08"/>
<!--
<property name="RINDEX" coldim="2" values="2.034*eV 1.56 4.136*eV 1.56"/>
<property name="SPECULARLOBECONSTANT" coldim="2" values="2.034*eV 0.3 4.136*eV 0.3 "/>
<property name="SPECULARSPIKECONSTANT" coldim="2" values="2.034*eV 0.2 4.136*eV 0.2 "/>
<property name="BACKSCATTERCONSTANT" coldim="2" values="2.034*eV 0.2 4.136*eV 0.2 "/>
-->
</opticalsurface>

<opticalsurface finish="polished" model="unified" name="MRICH_PhotoSensorOpticalSurface" type="dielectric_dielectric" value="0">
<!--
<property name="RINDEX" coldim="2" values="2.034*eV 1.35 4.136*eV 1.40"/>
<property name="SPECULARLOBECONSTANT" coldim="2" values="2.034*eV 0.3 4.136*eV 0.3 "/>
<property name="SPECULARSPIKECONSTANT" coldim="2" values="2.034*eV 0.2 4.136*eV 0.2 "/>
<property name="BACKSCATTERCONSTANT" coldim="2" values="2.034*eV 0.2 4.136*eV 0.2 "/>
-->
</opticalsurface>

<opticalsurface finish="polished" model="unified" name="MRICH_AerogelOpticalSurface" type="dielectric_dielectric" value="0">
<!--
<property name="RINDEX" coldim="2" values="2.034*eV 1.010 4.136*eV 1.010"/>
<property name="SPECULARLOBECONSTANT" coldim="2" values="2.034*eV 0.3 4.136*eV 0.3 "/>
<property name="SPECULARSPIKECONSTANT" coldim="2" values="2.034*eV 0.2 4.136*eV 0.2 "/>
<property name="BACKSCATTERCONSTANT" coldim="2" values="2.034*eV 0.2 4.136*eV 0.2 "/>
-->
</opticalsurface>

<!-- BEGIN dRICH and pfRICH optical surface properties
- to generate, follow: https://github.com/eic/drich-dev/blob/main/doc/material_tables.md
- original source for ATHENA/ECCE: https://github.com/cisbani/dRICh/blob/main/share/source/g4dRIChOptics.hh
Expand Down
21 changes: 0 additions & 21 deletions compact/pid/mrich.gdml
View file
Open in desktop

This file was deleted.

177 changes: 0 additions & 177 deletions compact/pid/mrich.xml
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions compact/pid/mrich_gdml.xml
View file
Open in desktop

This file was deleted.

50 changes: 0 additions & 50 deletions macro/mrich_vis.mac
View file
Open in desktop

This file was deleted.

Loading
Loading