Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes an obsolete detector geometry implementation file that has been superseded by a more specific implementation. The deleted file ScFiCalorimeter_geo.cpp declared a detector factory named epic_ScFiCalorimeter which is not referenced anywhere in the codebase. The functionality has been replaced by ZeroDegreeCalorimeterEcalWSciFi_geo.cpp which declares the ZDCEcalScFiCalorimeter detector factory that is actively used.
- Removes unused scintillating fiber calorimeter geometry code
- Cleans up legacy code that served as reference material for current implementations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
simonge
approved these changes
Dec 17, 2025
veprbl
added a commit
that referenced
this pull request
Feb 14, 2026
Unused file. Co-authored-by: Simon Gardner <simon.gardner@glasgow.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unused file.