Remove jacamar-ci-specific references; make project generic#3
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the repository more tool-agnostic after transfer to github.com/eic/panda-compose, removing jacamar-ci-specific naming and defaults while keeping CI and submission tooling functional.
Changes:
- Generalize README wording and rename the development section to be PanDA-stack focused.
- Update
pandajob-submitdefaults and add a--transformationsubmission mode; changeprocessingTypetopanda-compose. - Simplify CI installation of
panda-clientusingpip install --user panda-client.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
scripts/pandajob-submit |
Makes submission defaults generic; adds mutually-exclusive --script vs --transformation modes; updates processingType. |
README.md |
Removes jacamar-ci references; updates job-name default and development guidance. |
.github/workflows/ci.yml |
Switches CI to install panda-client via pip rather than a source install. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Update README description to be tool-agnostic - Rename 'Developing the jacamar-ci PanDA executor' section - Change default job name from 'jacamar-ci-job' to 'panda-compose-job' - Change processingType from 'jacamar-ci' to 'panda-compose' Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
wdconinc
force-pushed
the
remove-jacamar-refs
branch
from
dc45edb to
705847f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repository has been transferred to github.com/eic/panda-compose and is now more generally applicable. This PR:
jacamar-ci-jobtopanda-compose-jobprocessingTypefromjacamar-citopanda-composeinscripts/pandajob-submitAlso includes a previously merged fix: use
pip install --user panda-clientin CI instead of a manual source install.