Switch Jet Benchmarks to edm4eic::Jet#107
Merged
Merged
Conversation
14 tasks
wdconinc
reviewed
May 28, 2026
Contributor
wdconinc
left a comment
wdconinc
left a comment
There was a problem hiding this comment.
Seems to make sense to me. Did you test this by chance with a local file that has edm4eic::Jet entries?
Contributor
Actually, forget that. It must work since we are already running with EDM4eic 8.9.0 here. |
wdconinc
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
This PR updates the JES/R benchmark to work with the switch from
edm4eic::ReconstructedParticletoedm4eic::Jetimplemented in EICrecon#2674.What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply
If the EDM4eic version is 8.9.0 or greater, then this benchmark will also output histograms of the reconstructed/generated jet areas.