migrated form gradle to maven #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdurvak
force-pushed
the
migrationBranch
branch
2 times, most recently
from
f7dff0d to
eb2b526
Compare
raja-maragani
suggested changes
Jul 6, 2018
| <modelVersion>4.0.0</modelVersion> | ||
| <groupId>com.github.Ericsson</groupId> | ||
| <artifactId>eiffel-remrem-semantics</artifactId> | ||
| <version>0.4.6</version> |
pom.xml
Outdated
| <dependency> | ||
| <groupId>javax.inject</groupId> | ||
| <artifactId>javax.inject</artifactId> | ||
| <version>1</version> |
raja-maragani
suggested changes
Jul 11, 2018
pom.xml
Outdated
| <dependency> | ||
| <groupId>com.github.fge</groupId> | ||
| <artifactId>json-schema-validator</artifactId> | ||
| <version>2.2.8</version> |
Contributor
Author
There was a problem hiding this comment.
we are using it in only one place, do we need it as global property?
There was a problem hiding this comment.
Yes, Good to have. Please follow same for all components.
pom.xml
Outdated
| <version>2.9.4</version> | ||
| <scope>compile</scope> | ||
| </dependency> | ||
| <!-- https://mvnrepository.com/artifact/org.glassfish.hk2.external/javax.inject --> |
raja-maragani
suggested changes
Jul 11, 2018
pom.xml
Outdated
| <dependency> | ||
| <groupId>com.github.fge</groupId> | ||
| <artifactId>json-schema-validator</artifactId> | ||
| <version>2.2.8</version> |
There was a problem hiding this comment.
Yes, Good to have. Please follow same for all components.
xdurvak
force-pushed
the
migrationBranch
branch
3 times, most recently
from
5e202dd to
5f16b13
Compare
SantoshNC68
reviewed
Jul 23, 2018
|
|
||
| } | ||
|
|
||
| public Proxy getProxy() { |
Member
There was a problem hiding this comment.
change it to private,
move the resource bundle handling to class level. and change this code accordingly.
Calling the getProxy() twice see if we can reduce the calling of this method
pom.xml
Outdated
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <version>3.1</version> |
vasile-baluta
approved these changes
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made few changes in PrepareLocalEiffelSchemas class to clone the eiffel schema's repo behind the proxy also