basic artifact identifier validation #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ie3ce15c2aedba33643f74066eb872fb5269261ec
andmat900
requested review from
fredjn and
t-persson
and removed request for
a team
t-persson
reviewed
Oct 3, 2025
| ), f"Test runner {test_runner} not found" | ||
|
|
||
|
|
||
| class ArtifactValidator: |
Collaborator
There was a problem hiding this comment.
Isnt this validation already being made by the fact that we use StartEtosTestrun & StartEtos (or whatever they are called) pydantic models as input to our FastAPI functions?
I think the real problem with the ETOS API validation is that the client does not understand the response or we need to update the response code from the API (I think it is 422 Unprocessable Entity)
Contributor
Author
There was a problem hiding this comment.
I updated the field validator validate_id_or_identity so that 422 is returned when identity/id is present, but empty.
Collaborator
There was a problem hiding this comment.
Im happy with this change, but @fredjn will have to approve it
This reverts commit 3baf7ac.
Change-Id: I9d0bc8d32acf8b87c13933aee3511461ad8aef75
Change-Id: Ide38ae0b52e2658aad55b913223eb9675c2ae5a1
Change-Id: I9e89919fe2f8b5eb38fe4afad76929539ac2e546
fredjn
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
Description of the Change
This change adds a basic artifact identifier validation making sure the
startrequest gets a400 Bad Requestresponse if artifact validation fails.Alternate Designs
Possible Drawbacks
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Andrei Matveyeu, andrei.matveyeu@axis.com