Skip to content

feat: add Page Setup dialog (page size, orientation, margins)#124

Merged
jedrazb merged 3 commits intomainfrom
feat/document-properties
Mar 10, 2026
Merged

feat: add Page Setup dialog (page size, orientation, margins)#124
jedrazb merged 3 commits intomainfrom
feat/document-properties

Conversation

@jedrazb
Copy link
Contributor

@jedrazb jedrazb commented Mar 10, 2026

Summary

  • Adds Format > Page setup menu to the toolbar
  • New PageSetupDialog with page size presets (Letter, A4, Legal, A3, A5, B5, Executive), orientation toggle, and margin inputs in inches
  • Wired into DocxEditor to update finalSectionProperties via existing document change pattern
  • Lazy-loaded for zero startup overhead

Addresses the page setup portion of #31. Default font/paragraph style and document metadata can follow in separate PRs.

Test plan

  • Open editor, click Format > Page setup
  • Verify dialog shows current page size, orientation, and margins
  • Change page size preset — verify page dimensions update on Apply
  • Toggle orientation — verify width/height swap correctly
  • Adjust margins — verify page layout updates
  • Press Escape to cancel — verify no changes applied
  • Verify undo restores previous page layout

🤖 Generated with Claude Code

Adds a Format > Page setup menu entry that opens a dialog to configure
page dimensions (Letter, A4, Legal, etc.), orientation, and margins.
Addresses the page setup portion of #31.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vercel
Copy link

vercel bot commented Mar 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docx-editor Ready Ready Preview, Comment Mar 10, 2026 11:19pm

Request Review

@jedrazb jedrazb linked an issue Mar 10, 2026 that may be closed by this pull request
- Moved "Page setup" from standalone Format menu to File menu
- Fixed icon from 'description' (not in icon map) to 'settings'
- File menu now shows when either Print or Page setup is available

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jedrazb jedrazb merged commit b2c6ab3 into main Mar 10, 2026
4 checks passed
@jedrazb jedrazb deleted the feat/document-properties branch March 10, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document properties popup

1 participant