Merged
Conversation
Wendong-Fan
reviewed
Feb 18, 2026
Contributor
There was a problem hiding this comment.
thanks @Douglasymlai , fixed 2 issues below in commit cc6d655
- invalid providers can still be selected as default
- after BYOK validation succeeds, save may still persist a stale
is_validvalue instead oftrue.
Wendong-Fan
added a commit
that referenced
this pull request
Feb 18, 2026
This reverts commit 2a28d31.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
close #1180
What is the purpose of this pull request?