Skip to content

test: Integration tests for monero wallet#847

Open
codebestia wants to merge 9 commits into
eigenwallet:masterfrom
codebestia:feat/integration-for-monero-wallet
Open

test: Integration tests for monero wallet#847
codebestia wants to merge 9 commits into
eigenwallet:masterfrom
codebestia:feat/integration-for-monero-wallet

Conversation

@codebestia
Copy link
Copy Markdown

@codebestia codebestia commented Dec 30, 2025

Overview

Adds Integration tests for monero wallet

Sections Covered:

  • Opening existing wallets
  • Creating wallets
  • Restoring wallets
  • Transferring funds
  • Receiving funds
  • Transaction history
  • Changing the Monero node at runtime
  • Retrieving recently opened wallets
  • Tauri handle calls
  • TauriWalletListener
  • Swap wallet

Related Issues

Closes #800

Screenshot

Monero wallet tests

@codebestia codebestia marked this pull request as draft December 30, 2025 11:34
@codebestia codebestia marked this pull request as ready for review January 2, 2026 14:40
@codebestia
Copy link
Copy Markdown
Author

Hello @binarybaron
Please review.
The test suite is complete.

@codebestia codebestia changed the title test: Integration for monero wallet test: Integration test for monero wallet Jan 2, 2026
@codebestia codebestia changed the title test: Integration test for monero wallet test: Integration tests for monero wallet Jan 2, 2026
Copy link
Copy Markdown

Review pass for #800.

I could not run this against current master because the PR no longer applies cleanly (Cargo.lock and .github/workflows/ci.yml conflict). A few things to fix on rebase:

  • Current monero-wallet uses monero_address::Network / monero-oxide types. These new tests import monero::Network and pass it into Wallets::new / WalletHandle::open_or_create_from_seed, so those calls need to be updated to the current API after rebase.
  • The PR body says transfer coverage is included, but test_transfer_funds in monero-wallet/tests/transaction_tests.rs is commented out with TODO: test hangs.. find out why. CI will not cover transfers as written.
  • TauriWalletListener is made public only so integration tests can construct it. That widens the crate API for test access. Prefer testing through Wallets::new(..., Some(tauri_handle), ...), or move direct listener tests into an internal test module.
  • New deps look broader than what the visible tests use. mockito, proptest, swap-p2p, tracing-ext, plus build deps anyhow / vergen-git2, appear unused; monero-wallet also has no build.rs on current master.

Once it rebases cleanly and transfer coverage is either fixed or removed from the claimed scope, the harness will be much easier to validate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[0.75 XMR] Integration tests for Monero wallet

2 participants