Fix shard lifecycle cleanup, monitor recovery, and capability isolation #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Recover monitors and stale PIDs after ActorOwner restart.
- Terminate actors and purge ActorTable on shard ownership loss.
- Key ActorTable entries by {capability, module, id} to prevent collisions.
- Serialize sync_shards and gate capability propagation to avoid races.
- Update test infra for distributed rebalancing.
Fixes eigr#2
sleipnir
reviewed
Jan 10, 2026
Member
|
Hi @nshkrdotcom, this is beautiful, thank you for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
sync_shards/0and gate capability propagation to avoid transient races.Why
These fixes close lifecycle gaps that can leave stale registry entries, orphaned actors, or cross-capability collisions, and make shard sync deterministic under concurrent updates.
Fixes #2
Tests
mix test test/mesh/shard_lifecycle_test.exs --tracemix test test/mesh/shard_rebalancing_test.exs --trace