Skip to content

Add support for AXValue properties#5

Merged
eiz merged 3 commits intoeiz:masterfrom
tmandry:value-props
May 30, 2025
Merged

Add support for AXValue properties#5
eiz merged 3 commits intoeiz:masterfrom
tmandry:value-props

Conversation

@tmandry
Copy link
Copy Markdown
Contributor

@tmandry tmandry commented Jan 29, 2024

Seeking feedback on this approach. AXValue<T> is based on the way AXAttribute<T> works.

I have been using this API and personally am pretty happy with it. Unfortunately the implementation depends on servo/core-foundation-rs#652 which is still awaiting review, so I'm marking this PR as a draft in the meantime.

Comment thread accessibility/src/value.rs Outdated
@oNaiPs
Copy link
Copy Markdown

oNaiPs commented Sep 11, 2024

@eiz are you still maintaining this project?

@eiz
Copy link
Copy Markdown
Owner

eiz commented Mar 22, 2025

very slowly :P

it looks like the mentioned pr is merged, so can this proceed? approach looks fine

@tmandry
Copy link
Copy Markdown
Contributor Author

tmandry commented Mar 22, 2025

Unfortunately it's still blocked on upstream issuing a release (servo/core-foundation-rs#706). I just pinged that PR again.

@oNaiPs
Copy link
Copy Markdown

oNaiPs commented May 26, 2025

Hi there @eiz, FYI this just got unblocked :)

Unfortunately it's still blocked on upstream issuing a release (servo/core-foundation-rs#706). I just pinged that PR again.

Also please check my comment re: CGPoint

@eiz
Copy link
Copy Markdown
Owner

eiz commented May 30, 2025

@oNaiPs the CGPoint comment is resolved ya?

happy to get this in, just needs a rebase + mark ready for review

@tmandry
Copy link
Copy Markdown
Contributor Author

tmandry commented May 30, 2025

I rebased. I'm unsure what crate this should be getting types from now though.

  • core-graphics-types 0.1: Compatible with several years worth of releases; many crates surely still depend on the 0.1 line, but not the latest
  • core-graphics-types 0.2: Latest version of this crate, released 9 months ago, but may be declared deprecated and superseded by objc2-core-foundation (see Future of this project and discussion about objc2 servo/core-foundation-rs#729)
  • objc2-core-foundation 0.3: Released this year. Maybe the future?

I think eventually this crate will want to move to the objc2 crates, but it should probably be done all at once. I have a preference for sticking with the core-graphics-types 0.1 line in the meantime and skipping 0.2 so there's less churn.

@tmandry tmandry marked this pull request as ready for review May 30, 2025 05:44
@eiz eiz merged commit 1f68a65 into eiz:master May 30, 2025
@tmandry tmandry deleted the value-props branch May 30, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants