Skip to content

Conversation

@Bhaney44
Copy link

I added run.py to the repository to provide an executable script that runs the tutorial.

@Bhaney44
Copy link
Author

Hi @ejbaran - Wanted to follow up on this. Is the run.py file helpful? My intention was for it to be the single executable for the tutorial. Happy to continue collaborating on this project, please let me know if there is anything I can do to help!

@ejbaran
Copy link
Owner

ejbaran commented Jun 21, 2021

Hi @Bhaney44 - yes, I'm sure this would be helpful. It would be great to add the transfer and read balance pieces to complete it. Also, we should add all required imports at the top.

Ideally, it would also be great if we could do all the steps in one script, with a single run, which would mean we would need to dynamically grab the created asset ID instead of adding it to the config file manually. I'm happy forgoing this piece for now and just updating the pieces above. Just thought I'd put it out there.

@Bhaney44
Copy link
Author

Thanks @ejbaran! I will add: (1) the transfer, (2) the balance, and (3) the required imports. I will also start working on consolidating the files to a single script executable.

@Bhaney44
Copy link
Author

Hi @ejbaran I committed a new run.py file, cleaning up my original version and making it more accessible. The file is now organized according to the Tutorial, with six steps. I verified steps 1-5, however I am still stuck on step 6. I defined my error, as well as my strategy for solving the problem in Issue #4.

The new run.py file includes and appropriately labels: (1) the transfer, (2) the balance, and (3) the required imports. It is also a step toward the single executable script and includes all six steps for the LaylaCoin Tutorial. I will continue working toward solving the outstanding Issue and figuring out a way we can dynamically grab the created asset ID, as you mentioned, because that is an awesome idea.

Please let me know what you think of the new run.py file. I am happy to make any improvements or incorporate any changes. Also, thanks for the opportunity to contribute to LaylaCoin!

# LaylaCoin Tutorial
# Single Script Executable

# Imports
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are adding these at the appropriate steps below and the flow would be for a user to uncomment each step as they go along, then I would remove them. Right now they aren't really serving any purpose.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it - thanks! I removed the comments from the functional syntax.

@Bhaney44
Copy link
Author

Hi @ejbaran I made some changes to the main.py file in my branch, but your code looks a lot nicer. Is there a way we can just add the run.py file to master?

It seems like the next step for me is figuring out a way we can dynamically grab the created asset ID and working toward a single script executable. Please let me know what you think. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants