fix: restore ipv6_prefix to vm_state.config during snapshot run#563
Closed
claude-claude[bot] wants to merge 1 commit intorouted-ipv6-prefixfrom
Closed
fix: restore ipv6_prefix to vm_state.config during snapshot run#563claude-claude[bot] wants to merge 1 commit intorouted-ipv6-prefixfrom
claude-claude[bot] wants to merge 1 commit intorouted-ipv6-prefixfrom
Conversation
Add the missing `vm_state.config.ipv6_prefix` restoration alongside other config fields in the snapshot run path. Without this, cascaded snapshots (creating a snapshot from a clone) lose the prefix because `build_snapshot_config()` reads from `vm_state.config`. Also fix README CLI reference: `<CIDR>` → `<PREFIX>` to match the actual input format (4 colon-separated hex groups, not CIDR notation). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Owner
|
Cherry-picked into routed-ipv6-prefix (0953b6e). Not needed as separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-Fix for PR #559
Issues Fixed
ipv6_prefixnot restored tovm_state.configduringsnapshot run: The snapshot restore path passesipv6_prefixtoRoutedNetwork::with_ipv6_prefix()for networking setup, but never writes it back tovm_state.config. This meansbuild_snapshot_config()readsNonefromvm_state.config.ipv6_prefix, breaking cascaded snapshot chains.<CIDR>instead of<PREFIX>: The--ipv6-prefixflag takes 4 colon-separated hex groups (e.g.,2803:6084:7058:46f6), not CIDR notation.Changes
src/commands/snapshot.rs: Addvm_state.config.ipv6_prefix = snapshot_config.metadata.ipv6_prefix.clone()alongside the other config restorations.README.md: Change--ipv6-prefix <CIDR>to--ipv6-prefix <PREFIX>.Generated by Claude | Review Run