MNT: Replace fromstring with frombuffer, bump numpy minversion#930
Conversation
ejeschke
left a comment
There was a problem hiding this comment.
@pllim , what version of numpy deprecates fromstring? I think there are a few instances where ginga checks for frombuffer and falls back to fromstring (and similar for tobuffer/tostring ?). If we are only supporting numpy versions that have frombuffer/tobuffer then we can modify those sections too.
|
If I understand https://numpy.org/doc/stable/reference/generated/numpy.fromstring.html correctly, it has been deprecated since 1.14. I am not familiar with |
|
Then.., currently install_requires = numpy>=1.13maybe we should bump that to 1.14 in this PR? What do you think? I can submit a separate PR to tackle the other cases, if I find any. |
|
1.14 is pretty old. Even astropy only support |
to avoid DeprecationWarning
|
@plllim, shall I SAM (Squash And Merge)? 😃 Or are you planning to push more commits? |
|
@ejeschke , feel free to SAM. I am done here. Thanks! 😸 |
I see this warning while working on astropy/astrowidgets#125