Docker support#2
Conversation
…sion while maintaining airport and display airport integrity. Allowing for changes in config for potential future updates
… reporting field was not being implemented
… forsee a ton of bug potential there.
Add LED and display smoke test to setup script
…es in case others are keeping their own repo
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f5cc29a02d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| import board | ||
| import neopixel |
There was a problem hiding this comment.
The inline smoke test imports board and neopixel before entering its try block, so on Docker/non-Pi hosts (or any environment where those modules cannot initialize) Python exits immediately and setup.sh fails because the script is running with set -e. This turns a post-install validation step into a hard blocker for setup/update in unsupported environments; move these imports inside the guarded block or skip hardware tests when imports fail.
Useful? React with 👍 / 👎.
1 participant
No description provided.