fix(config): handle branches with multiple slashes in their names#485
Merged
ejoffe merged 1 commit intoejoffe:masterfrom Mar 12, 2026
Merged
Conversation
ejoffe
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #415
The regex used to parse
git statusoutput for remote branch detection was too greedy on the remote name part, incorrectly consuming slashes that belong to the branch name.For example, with a branch like
feature/foo/bartrackingorigin/feature/foo/bar, the regex would matchorigin/featureas remote andfoo/baras branch instead oforiginas remote andfeature/foo/baras branch.Changes:
/from the remote name capture group in the regex, since remote names don't contain slashesGitHubBranchif already set (e.g. from config), only falling back to the parsed value