Skip to content

Conversation

@zeitounator
Copy link
Contributor

Finally took the time to find out why I was getting empty tocs once in a while....

I move between my personal office and clients location where I'm frequently behind a proxy. I don't always set the outgoing proxy in my shell. It happens that gh-md-toc needs network connectivity, even to parse local file. But it fails silently with an empty toc in those cases. This is misleading.

This PR fixes this and fails with a message to check network connection, both for remote and local files.

@zeitounator
Copy link
Contributor Author

Hi. I saw the travis test is failing. After having a closer and running the tests locally on the current master, it looks like it comes from the remote examples which changed structures. Should I fix this in this same PR ?

@ekalinin
Copy link
Owner

Hi @zeitounator

Thanks for the PR!

I saw the travis test is failing. After having a closer and running the tests locally on the current master, it looks like it comes from the remote examples which changed structures. Should I fix this in this same PR ?

No, you should not. It's not related to your changes.

@ekalinin ekalinin merged commit fa45ba5 into ekalinin:master Sep 11, 2018
@zeitounator
Copy link
Contributor Author

@ekalinin My pleasure ! Thanks for your fast reaction.

@zeitounator zeitounator deleted the fix/silentFailNoNetwork branch November 9, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants