Switch from template-haskell to template-haskell-lift#105
Switch from template-haskell to template-haskell-lift#105RyanGlScott merged 1 commit intoekmett:masterfrom
Conversation
|
Let me know when you'd like a full review of this. (It looks like there is still some work to be done to make this pass CI.) |
ab9c9a9 to
224546d
Compare
|
@RyanGlScott in the current version I have set things up to only use this library when GHC >=9.14. template-haskell-lift itself is compatible with GHC>=8.10. But it is only a boot library with GHC>=9.14. So you wouldn't be able to backport new releases of exceptions to older GHCs as a boot lib (they would build fine from Hackage though). Do you have a preference?
|
e67d2ae to
9fbde92
Compare
|
Given that |
5078767 to
c044d17
Compare
|
Great! When would be a good time for merging this? My understanding is that we want this to coincide with GHC 9.14 bundling |
Not yet. The MR still needs to be backported to the GHC-9.14 branch. I think it would be best to wait until 9.14.1 is released and then we can add a proper CI job to test this. And then 9.14.2 could perhaps ship with a version of exception that has this patch. |
This new boot library should be more stable than template-haskell and should eventually allow us to remove much of the CPP around TH. It will also make it easier for end-users to reinstall template-haskell as it will no longer be used by any boot libraries
|
This should be ready for review now, since GHC 9.14 is out |
| -- this conditional can be dropped | ||
| if impl(ghc < 9.14) | ||
| build-depends: template-haskell | ||
| else |
There was a problem hiding this comment.
This new boot library should be more stable than template-haskell and
should eventually allow us to remove much of the CPP around TH.
It will also make it easier for end-users to reinstall template-haskell
as it will no longer be used by any boot libraries
This GHC MR tests this PR against GHC-HEAD: https://gitlab.haskell.org/ghc/ghc/-/merge_requests/14978