Conversation
ekpyron
force-pushed
the
emscriptenBuild
branch
2 times, most recently
from
ec98c1e to
e605674
Compare
ekpyron
force-pushed
the
emscriptenBuild
branch
22 times, most recently
from
14a2bd3 to
5814e72
Compare
ekpyron
force-pushed
the
emscriptenBuild
branch
3 times, most recently
from
9f9cc09 to
7b167d0
Compare
ekpyron
commented
Aug 10, 2020
Comment on lines
+13
to
+18
| if(DEFINED MSVC) | ||
| # Install the required MSVC*.DLL libraries. | ||
| include(InstallRequiredSystemLibraries) | ||
| install(FILES ${CMAKE_INSTALL_SYSTEM_RUNTIME_LIBS} DESTINATION bin COMPONENT Libraries) | ||
| endif() | ||
|
|
Owner
Author
There was a problem hiding this comment.
This makes CMake choose the DLLs to install instead of us manually packaging the wrong ones...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.