Skip to content

Enable to declare AttachIDs, WithShared and WithLocal in config file#490

Merged
errordeveloper merged 1 commit into
eksctl-io:masterfrom
af12066:v1alpha4-sgs
Jan 30, 2019
Merged

Enable to declare AttachIDs, WithShared and WithLocal in config file#490
errordeveloper merged 1 commit into
eksctl-io:masterfrom
af12066:v1alpha4-sgs

Conversation

@af12066
Copy link
Copy Markdown
Contributor

@af12066 af12066 commented Jan 30, 2019

Description

We have made it possible to declare attachIDs, withShared and/or withLocal for security groups in cluster.yaml

e.g.

apiVersion: eksctl.io/v1alpha4
kind: ClusterConfig

nodeGroups:
  - name: nodegroup1
    securityGroups:
      attachIDs:
        - sg-abcd1234
        - sg-567890ef
    ...

cf. #460

Checklist

  • Code compiles correctly (i.e make build)
  • Added tests that cover your change (if possible)
  • All tests passing (i.e. make test)
  • Added/modified documentation as required (such as the README)
  • Added yourself to the humans.txt file

@errordeveloper
Copy link
Copy Markdown
Contributor

Thanks! Clearly something that was overlooked in review :)

@errordeveloper errordeveloper merged commit 8744bd7 into eksctl-io:master Jan 30, 2019
@af12066 af12066 deleted the v1alpha4-sgs branch January 30, 2019 09:00
torredil pushed a commit to torredil/eksctl that referenced this pull request May 20, 2022
…r@v2.1.1

Update kubernetes-csi/external-snapshotter components to v2.1.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants