Adding support for upgrading eks hybrid nodes on EKS clusters#8719
Merged
michaelhtm merged 2 commits intoeksctl-io:mainfrom Apr 30, 2026
Merged
Adding support for upgrading eks hybrid nodes on EKS clusters#8719michaelhtm merged 2 commits intoeksctl-io:mainfrom
michaelhtm merged 2 commits intoeksctl-io:mainfrom
Conversation
Contributor
|
Hello pokearu 👋 Thank you for opening a Pull Request in |
michaelhtm
reviewed
Apr 29, 2026
vikash-s1
reviewed
Apr 30, 2026
| } | ||
|
|
||
| func (c *OwnedCluster) updateRemoteNetworkConfig(ctx context.Context, dryRun bool) (bool, error) { | ||
| if c.cfg.RemoteNetworkConfig == nil { |
There was a problem hiding this comment.
nit. Is it worth to add check?
if rnc.RemoteNodeNetworks == nil && rnc.RemotePodNetworks == nil {
logger.Info("no remote node or pod networks specified, skipping update")
return false, nil
}
Contributor
Author
There was a problem hiding this comment.
So actually that's not a skip. Its a valid use case where they want to remove remote networks and make a cluster non-hybrid.
michaelhtm
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for updating
remoteNetworkConfigon existing EKS clusters througheksctl upgrade cluster. Previously, remote network config could only be set during cluster creation — this change allows users to enable hybrid nodes, update CIDRs, or remove remote networks on existing clusters.What this does:
updateRemoteNetworkConfigto theUpgradeflow inowned.go, called between version upgrade and CFN stack updateremoteNetworkConfigdirectly to the EKSUpdateClusterConfigAPI.[]sends an empty array (removes)remoteNodeNetworks: []andremotePodNetworks: []simultaneously (the "remove all" case), matching the EKS API'svalidateRemoteNetworkConfigUpdateRequestbehaviorUsage:
Design decisions:
• Lives in upgrade cluster (not a utils command) because enabling hybrid nodes also requires CFN resources (VPC routes, IAM roles) which AppendNewClusterStackResource handles
• No client-side re-implementation of API validations — bad input gets clear API errors
• No defaulting — omitting remotePodNetworks sends nil (no change), setting it to [] sends empty (remove)
Testing
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯