PR benchmark guard (base vs head) #1676
AnshulPatil2005
started this conversation in
Ideas
Replies: 1 comment 1 reply
-
|
That all sounds like a reasonable place to start. Let's see how this goes and then decide how to adjust as necessary once it's running. I have the feeling we won't ever make this blocking, due to too much of it being out of our control, but it'll be nice to have the data. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Add a lightweight PR benchmark workflow that runs base and head on the same runner and posts non-blocking regression warnings per case.
this idea is from Part 2 Task 1 of (opencax/GSoC#114 (comment))
Proposed approach
.github/workflows/manifold.ymlbasevsheadon the same runner using separate git worktreesextras/perfTestas the initial benchmark target>= 20%and>= 10 msConfirmation needed
perfTestthe right initial target, or should I switch to another benchmark entry point?20%+10ms) acceptable for first rollout?does this look good ?
Beta Was this translation helpful? Give feedback.
All reactions