Add flaky test triage workflow template#166
Conversation
Add a new flaky-test-triage workflow template, trigger example, and docs entry.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
/ai do a dry run against the elastic-agent repo here https://github.com/elastic/elastic-agent In that repo they have a flakey-test label . We dont want to hard code this label name but should allow you to role play as this agent and see if the flow makes sense. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Implemented a follow-up fix on this PR to avoid hardcoding flaky label names and better match your What changed:
Validation run:
Pushed to PR #166 in commit What is this? | From workflow: PR Assistant Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. for issue #166 |
There was a problem hiding this comment.
Approving from a code-quality perspective: no actionable issues found in this PR.
What is this? | From workflow: PR Review Agent
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. for issue #166
|
@copilot please fix merge conflicts |
|
@strawgate I've opened a new pull request, #181, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: strawgate <6384545+strawgate@users.noreply.github.com>
There was a problem hiding this comment.
Verdict: REQUEST_CHANGES.
Please address the inline MEDIUM-severity finding before merge.
What is this? | From workflow: PR Review Agent
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. for issue #166
| pull-requests: read | ||
| tools: | ||
| github: | ||
| toolsets: [repos, issues, pull_requests, search, actions] |
There was a problem hiding this comment.
🟡 MEDIUM — Missing labels toolset for required label discovery
The workflow prompt requires discovering repository labels (flaky, flakey, intermittent) before issue search, but tools.github.toolsets omits labels, so the agent cannot reliably list labels and satisfy step 1 of the assignment. Please add labels to the toolset list so the prompt instructions are executable.
|
The CI failure is caused by generated workflow artifacts not being committed for this PR branch.
Recommended fix:
What I ran:
What is this? | From workflow: PR CI Detective Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
|
CI failure is reproducible and is caused by From run
Local reproduction (checked out
Likely root causes:
I did not push a fix from this run because resolving this check requires updating tracked generated files in Recommended remediation in a maintainer follow-up:
What is this? | From workflow: PR Checks Fixer Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
|
@copilot -- let's raise the bar for flakey test fixes, we have to be really sure it's the real fix and not a workaround, blah blah, only propose a fix if you have the true root cause and it really fixes it. Noop is better than giving a bad fix. |
|
@strawgate I've opened a new pull request, #184, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: strawgate <6384545+strawgate@users.noreply.github.com>
|
CI failed in Verify compiled workflows (job Root cause from logs: generated workflow artifacts are not committed for this PR state. The failing step prints modified lockfiles across many existing workflows plus two untracked generated workflow files:
Recommended fix:
Tests/log checks run by this investigation:
What is this? | From workflow: PR CI Detective Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
Summary
github/workflows/gh-aw-flaky-test-triage.md(copy location required by workflow-edit guardrails)gh-agent-workflows/flaky-test-triage/example.ymlwith weekday schedule, manual dispatch, and failedworkflow_runtriggergh-agent-workflows/flaky-test-triage/README.mddocumenting install/trigger/inputs/safe outputsdocs/workflows/gh-agent-workflows.mdNotes
.github/workflows/; a maintainer should relocategithub/workflows/gh-aw-flaky-test-triage.mdto.github/workflows/gh-aw-flaky-test-triage.mdbefore compiling lock filesValidation
make lintbin/actionlint gh-agent-workflows/flaky-test-triage/example.ymlFixes Add Flaky Test Triage #153