Add ready-to-make-pr safe input preflight for PR/push workflows

[github-actions]

Summary

• add scripts/ready-to-make-pr.sh, a shell-based readiness checklist tool that returns JSON reminders to:
  • review contributing guidance
  • follow the PR template
  • confirm the assigned task is complete and validated
• add workflow-fragment copies under github/workflows/gh-aw-fragments/ for:
  • safe-output-create-pr.md
  • safe-output-push-to-pr.md
• wire both fragment copies with a new safe input ready-to-make-pr and explicit instructions to call ready_to_make_pr before create_pull_request / push_to_pull_request_branch

Why files are under github/

The runtime rejects PRs that directly modify .github/workflows/. These are relocation-ready copies that a maintainer can move to:

• .github/workflows/gh-aw-fragments/safe-output-create-pr.md
• .github/workflows/gh-aw-fragments/safe-output-push-to-pr.md

Validation

• bash scripts/ready-to-make-pr.sh | python -m json.tool
• make lint (passes)

Notes

• this is intentionally lightweight: the tool currently provides guidance (not hard enforcement), matching the issue request for a reminder/preflight step.

• Fixes Add ready to make pr tool #208

AI generated by Issue Assistant

[github-actions]

CI failed in Verify compiled workflows at step Ensure lock files are up to date because make compile left the working tree dirty (untracked generated workflow files), so the guard in .github/workflows/ci.yml exits with code 1.

Evidence from run 22229822434:

• failing job: Verify compiled workflows
• failing step: Ensure lock files are up to date
• untracked files printed by git status --porcelain:
  • .github/workflows/gh-aw-docs-new-contributor-review-external.lock.yml
  • .github/workflows/trigger-docs-drift-external.yml
  • .github/workflows/trigger-docs-new-contributor-review-external.yml

Recommended fix (minimal):

1. Regenerate workflow outputs locally: ````bash
   make compile

2. Commit the generated files so the repo is clean after compile (or, if these outputs are not intended, adjust the source fragments so compile no longer emits them).
3. Re-run CI.

Tests run by me:

• No local test execution; analysis performed from GitHub Actions job list and logs for run 22229822434.

---

What is this? | From workflow: PR CI Detective

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

[github-actions]

The failed check is caused by compile drift, not by the new scripts/ready-to-make-pr.sh logic.

• Failing job: Verify compiled workflows (job 64306124512), step Ensure lock files are up to date.
• The CI check at .github/workflows/ci.yml:L39-L44 fails when git status --porcelain is non-empty after make compile.
• In run 22229822434, logs show Working tree dirty after make compile. followed by many .github/workflows/* changes and new files (including gh-aw-docs-drift-external.lock.yml, gh-aw-docs-new-contributor-review-external.lock.yml, and trigger-docs-*-external.yml).

I reproduced locally with:

• make compile
• git status --porcelain

Result: 33 generated changes under .github/workflows/ (same pattern as CI).

Recommended remediation:

1. Regenerate workflow artifacts with make compile.
2. Commit the resulting .github/workflows/ updates (modified lock files + the new external trigger/lock files).
3. Re-run CI.

I did not push a fix from this run because the required changes are in .github/workflows/, which is restricted in this workflow environment.

---

What is this? | From workflow: PR Checks Fixer

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

[github-actions]

Approved: I found no blocking issues in this PR.

---

What is this? | From workflow: PR Review Agent

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. for issue #215

[github-actions]

The failure is caused by generated workflow artifacts not being committed after your fragment changes. In run 22230435590, job Verify compiled workflows fails at Ensure lock files are up to date because make compile leaves the tree dirty (many *.lock.yml updates plus new trigger-docs-*-external.yml files in .github/workflows/).

Root cause evidence:

• .github/workflows/gh-aw-fragments/safe-output-create-pr.md lines 2-20 added safe-inputs.ready-to-make-pr and new instruction text.
• .github/workflows/gh-aw-fragments/safe-output-push-to-pr.md lines 2-19 added the same safe-input block/instruction.
• These fragment changes alter compiled outputs across the generated lock workflows, but those generated files were not included in the PR.

What to do:

1. Run make compile locally on this branch.
2. Commit the resulting generated files under .github/workflows/ (updated lock files + the two new external trigger/lock files).
3. Push and rerun CI.

Validation I ran:

• make compile (exit 0)
• Confirmed dirty tree matches CI failure pattern (.github/workflows/*.lock.yml modifications and new external workflow files).

I did not push a commit from this run.

---

What is this? | From workflow: PR Checks Fixer

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.