[downstream] add downstream updates-needed internal workflow draft#253
[downstream] add downstream updates-needed internal workflow draft#253github-actions[bot] wants to merge 3 commits intomainfrom
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughAdds a scheduled trigger and an analyzer workflow that reads downstream repository workflow entries (elastic/, strawgate/), validates a new object-based data model including explicit refs, compares refs against recommended/latest versions, and files per-repo issues listing required updates. Changes
Sequence DiagramsequenceDiagram
actor Scheduler
participant Trigger as Trigger Workflow
participant Analyzer as Downstream Analyzer
participant Data as data/downstream-users.json
participant Registry as Action Registry (latest/recommended)
participant Issues as GitHub Issues
Scheduler->>Trigger: scheduled/dispatch
Trigger->>Analyzer: workflow_call + COPILOT_GITHUB_TOKEN
Analyzer->>Data: read downstream repos (elastic/*, strawgate/*)
Analyzer->>Analyzer: validate object model (workflow_file, uses_target, ref)
Analyzer->>Registry: fetch latest_version & recommended_floating_major per uses_target
Analyzer->>Analyzer: compute recommended_ref and reason per entry
Analyzer->>Issues: create repo-scoped issue with table of findings (or noop if all up to date)
Issues-->>Analyzer: issue created / noop acknowledged
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related issues
Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Verdict: request changes.
What is this? | From workflow: PR Review Agent
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. for issue #253
| cancel-in-progress: true | ||
| permissions: | ||
| contents: read | ||
| issues: read |
There was a problem hiding this comment.
🟠 HIGH: Insufficient issue permission for configured output
This workflow enables safe-outputs.create-issue, but the declared permission is issues: read, which prevents issue creation at runtime.
| issues: read | |
| issues: write |
|
|
||
| jobs: | ||
| run: | ||
| uses: ./.github/workflows/gh-aw-downstream-updates-needed.lock.yml |
There was a problem hiding this comment.
🟠 HIGH: Trigger points to a missing reusable workflow
This job references .github/workflows/gh-aw-downstream-updates-needed.lock.yml, but that file is not present in this PR. As written, scheduled/dispatch runs will fail immediately because the called workflow cannot be resolved.
Please include the compiled lock file in this change (or defer adding this trigger until the lock file exists).
|
CI run Root cause from logs: generated lock YAML had a duplicate key ( I did not push a fix because this PR is already closed; recommended remediation is to edit What is this? | From workflow: PR Checks Fixer Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
Summary
This PR adds an internal downstream update-check workflow that reviews
data/downstream-users.jsonentries forelastic/*andstrawgate/*, compares workflow refs to the latestelastic/ai-github-actionsrelease, and reports required updates by repository.It also updates the downstream inventory workflow prompt so collected entries retain structured
workflow_file,uses_target, andrefmetadata, adds a scheduled/dispatch trigger workflow for the updates-needed check, and updates docs to listgh-aw-downstream-updates-neededas an internal-only workflow under.github/workflows/.Context
Fixes #245.What is this? | From workflow: PR Body Update Agent
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
Summary by CodeRabbit
New Features
Documentation