Skip to content

Comments

Exclude pr-review-fork from dogfood sync and clarify skipped output#308

Merged
strawgate merged 2 commits intomainfrom
main-fd433edeb6860d93
Feb 21, 2026
Merged

Exclude pr-review-fork from dogfood sync and clarify skipped output#308
strawgate merged 2 commits intomainfrom
main-fd433edeb6860d93

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Feb 21, 2026

Summary

  • Added pr-review-fork to EXCLUDED_WORKFLOWS in scripts/dogfood.sh so dogfood sync no longer enables both PR review triggers.
  • Updated skipped-workflow output to include manual sync required so workflow authors get an explicit signal when a trigger is intentionally not synced.

Validation

  • bash -n scripts/dogfood.sh
  • make sync (verified pr-review-fork is skipped with the new message)

Why

This addresses issue #295 by disabling the fork review trigger in dogfood and making skipped workflow behavior explicit for agents/maintainers.


What is this? | From workflow: Mention in Issue

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. for issue #295

Summary by CodeRabbit

  • Chores
    • Updated automated workflow handling to exclude an additional workflow from automatic processing.
    • Improved status messaging to indicate when an excluded workflow requires manual synchronization, making workflow state clearer and reducing confusion for maintainers.

Add pr-review-fork to excluded workflows and clarify skipped workflows require manual sync.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@coderabbitai
Copy link

coderabbitai bot commented Feb 21, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Removed a fork-oriented GitHub Actions workflow and updated a dogfooding script to treat pr-review-fork as excluded, changing the skip message to indicate manual sync is required.

Changes

Cohort / File(s) Summary
Script: workflow exclusions
scripts/dogfood.sh
Added "pr-review-fork" to EXCLUDED_WORKFLOWS and changed the emitted skip message from "(excluded)" to "(excluded — manual sync required)".
Workflow removed
.github/workflows/trigger-pr-review-fork.yml
Deleted the fork-oriented PR review GitHub Actions workflow that triggered on pull_request_target events and reused gh-aw-pr-review.lock.yml. Removal addresses duplicate PR-review trigger.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐇 I nibbled code beneath the moonlit fork,
Removed a workflow, left one little cork,
The script now whispers, soft and succinct,
"(excluded — manual sync required)" — hop to the link! 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: excluding pr-review-fork from dogfood sync and clarifying the skipped workflow output message.
Linked Issues check ✅ Passed The changes directly address issue #295 by excluding pr-review-fork from dogfood sync to prevent duplicate PR review triggers from running.
Out of Scope Changes check ✅ Passed All changes are within scope: excluding a workflow and updating messaging align with the stated objective of disabling the fork review trigger.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch main-fd433edeb6860d93

Comment @coderabbitai help to get the list of available commands and usage tips.

@strawgate strawgate marked this pull request as ready for review February 21, 2026 04:43
@strawgate
Copy link
Collaborator

@copilot dont we also have to remove the active workflow for that too?

Copy link
Contributor

Copilot AI commented Feb 21, 2026

@strawgate I've opened a new pull request, #309, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Contributor Author

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE. I found no new issues in this PR.


What is this? | From workflow: PR Review

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. for issue #308

…309)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: strawgate <6384545+strawgate@users.noreply.github.com>
@strawgate strawgate merged commit f7a3bb9 into main Feb 21, 2026
7 of 13 checks passed
@strawgate strawgate deleted the main-fd433edeb6860d93 branch February 21, 2026 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

We have two PR review triggers running

2 participants