Exclude pr-review-fork from dogfood sync and clarify skipped output#308
Exclude pr-review-fork from dogfood sync and clarify skipped output#308
pr-review-fork from dogfood sync and clarify skipped output#308Conversation
Add pr-review-fork to excluded workflows and clarify skipped workflows require manual sync. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughRemoved a fork-oriented GitHub Actions workflow and updated a dogfooding script to treat Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@copilot dont we also have to remove the active workflow for that too? |
|
@strawgate I've opened a new pull request, #309, to work on those changes. Once the pull request is ready, I'll request review from you. |
There was a problem hiding this comment.
Verdict: APPROVE. I found no new issues in this PR.
What is this? | From workflow: PR Review
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. for issue #308
…309) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: strawgate <6384545+strawgate@users.noreply.github.com>
Summary
pr-review-forktoEXCLUDED_WORKFLOWSinscripts/dogfood.shso dogfood sync no longer enables both PR review triggers.manual sync requiredso workflow authors get an explicit signal when a trigger is intentionally not synced.Validation
bash -n scripts/dogfood.shmake sync(verifiedpr-review-forkis skipped with the new message)Why
This addresses issue #295 by disabling the fork review trigger in dogfood and making skipped workflow behavior explicit for agents/maintainers.
What is this? | From workflow: Mention in Issue
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. for issue #295
Summary by CodeRabbit