Conversation
…is scripts - Update gh-aw-agent-efficiency.md: 7-day lookback with explicit dates, pre-download failed run logs/error snippets in frontmatter step, refocus analysis on bad agent behavior (excessive tool calls, wrong tool usage, instruction violations), remove suggested fixes and impact sections - Add gh-aw-agent-deep-dive.md: new workflow that deep dives one agent at a time, rotates through workflows by day-of-week or uses target-workflow input - Add scripts/fetch-workflow-logs.py: download job logs for a workflow's recent runs - Add scripts/extract-log-errors.py: extract error/failure lines with surrounding context - Add gh-agent-workflows/agent-deep-dive/README.md and example.yml - Regenerate lock files and trigger via make compile" Co-authored-by: strawgate <6384545+strawgate@users.noreply.github.com>
|
@copilot I forgot this would be an internal workflow so we can write whatever scripts we need to the scripts folder and the agent can use them which should also make testing them much easier |
Exactly — since the |
There was a problem hiding this comment.
Requesting changes for two functional issues that can cause incorrect workflow behavior and filtering.
What is this? | From workflow: PR Review
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
|
@copilot please review and address feedback |
- scripts/fetch-workflow-logs.py: normalize date-only --until values to end-of-day T23:59:59Z so same-day runs are correctly included - gh-aw-agent-deep-dive.md: set NO_WORKFLOWS=true env flag when no agentic workflows are found; add pre-flight check in prompt to call noop immediately when NO_WORKFLOWS is true" Co-authored-by: strawgate <6384545+strawgate@users.noreply.github.com>
Addressed both review findings in 23141af:
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot these should be internal workflows not published ones |
There was a problem hiding this comment.
Requesting changes to make the pre-extracted error JSON artifacts deterministic when no failed logs exist, so downstream analysis does not depend on missing files.
What is this? | From workflow: PR Review
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
- Remove gh-aw-agent-efficiency.md, gh-aw-agent-efficiency.lock.yml, trigger-agent-efficiency.yml - Remove gh-aw-agent-deep-dive.md, gh-aw-agent-deep-dive.lock.yml, trigger-agent-deep-dive.yml - Remove gh-agent-workflows/agent-efficiency/ and gh-agent-workflows/agent-deep-dive/ directories - Create agent-efficiency.md (internal, schedule-triggered, no workflow_call) - Create agent-deep-dive.md (internal, schedule-triggered with workflow_dispatch inputs) - Regenerate agent-efficiency.lock.yml and agent-deep-dive.lock.yml" Co-authored-by: strawgate <6384545+strawgate@users.noreply.github.com>
Done in b08577c. Both
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot can you address the PR feedback please |
…cified
When no log files are found, write an empty JSON payload
{total_files_scanned: 0, total_matches: 0, matches: []}
so downstream agents always have a consistent file to read"
Co-authored-by: strawgate <6384545+strawgate@users.noreply.github.com>
Fixed in d57456c. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
/ai can you please resolve open review threads that have been taken care of? |
|
Resolved the open review threads that are already addressed in the current PR state. I verified the fixes are present for:
What is this? | From workflow: Mention in PR Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
Summary
.github/workflows/..github/workflows/agent-deep-dive.md..github/workflows/agent-efficiency.md..github/workflows/agent-efficiency.lock.yml..github/workflows/gh-aw-agent-efficiency.md.github/workflows/trigger-agent-efficiency.ymlgh-agent-workflows/agent-efficiency/README.mdgh-agent-workflows/agent-efficiency/example.ymlLog analysis tooling
scripts/fetch-workflow-logs.pyto download workflow run logs with filtering (--since,--until,--conclusion,--last) and emit a manifest.scripts/extract-log-errors.pyto extract warning/error/failure snippets with surrounding context from downloaded logs.Review feedback addressed
--untildate-only handling inscripts/fetch-workflow-logs.pyby normalizing date-only input to an inclusive UTC end-of-day timestamp.NO_WORKFLOWS=truegating in.github/workflows/agent-deep-dive.mdand explicitnoopbehavior when no agentic workflows are found.scripts/extract-log-errors.pyto always write--outputeven when no log files are found (writes an empty structured result).Additional related update
.github/workflows/trigger-project-summary.ymlto passadditional-instructionsintogh-aw-project-summary.lock.ymlfor narrative-style project summaries.