Skip to content

[CI] Full build and test on Windows - weekly #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jan 31, 2022
Merged

[CI] Full build and test on Windows - weekly #1705

merged 15 commits into from
Jan 31, 2022

Conversation

@v1v
Copy link
Member

@v1v v1v commented Mar 17, 2021 •
edited
Loading

What does this PR do?

Run on Windows but on a weekly basis:

  • Build on windows
  • Test (verify maven goal) on windows
  • If any failures then it will notify to the slack channel.

It can be executed on a PR basis with the GitHub comment: windows tests or using the UI with the new parameter windows-ci or GitHub label ci:windows

Why

Simplify the default CI pipeline.

Issues

See #1703 (comment)

UX

image

@ghost
Copy link

ghost commented Mar 17, 2021 •
edited by ghost
Loading

❕ Build Aborted

There is a new build on-going so the previous on-going builds have been aborted.

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Reason: Aborted from #206

  • Start Time: 2022-01-31T13:28:02.301+0000

  • Duration: 9 min 18 sec

  • Commit: c610bc8

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

v1v
v1v commented Mar 24, 2021
View reviewed changes
@v1v v1v self-assigned this Mar 24, 2021
@v1v v1v added the automation Tests & automation that help build & maintain the project label Mar 24, 2021
@v1v v1v requested review from a team March 24, 2021 15:40
@v1v v1v marked this pull request as ready for review March 24, 2021 15:40
@v1v
Copy link
Member Author

v1v commented Mar 25, 2021

@eyalkoren, if we merge this then you could use it to test #1671 in the CI. Though it will require to kick off a build with the specific refspec (see the screenshot in the description)

@eyalkoren eyalkoren changed the title [CI] single pipeline to run mvn verify on windows [CI] Full build and test on Windows - weekly May 5, 2021
v1v and others added 6 commits May 17, 2021 09:41
@v1v
Merge branch 'master' into feature/pipeline-for-windows-only
c8eff63
@v1v
Merge remote-tracking branch 'upstream/master' into feature/pipeline-…
178844e 
…for-windows-only

* upstream/master: (100 commits)
  [CI] Enable compatibility test matrix for unit tests (elastic#1915)
  Updated get-user-teams-membership to version 1.0.3
  ensure that the socket is closed even if there is an exception from the other close (elastic#1946)
  Make sure trace context headers are added only once (elastic#1937)
  Update CHANGELOG.asciidoc
  Ecs reformatting more fields (elastic#1910)
  Use path when high-level framework method is unknown (elastic#1906)
  Semver parsing enhancement (elastic#1931)
  Bump version.slf4j from 1.7.31 to 1.7.32 (elastic#1933)
  Add description about memory pool metrics to docs (elastic#1925)
  updated team membership check in action
  Add 1.25.0 to cloudfoundry index
  Update CHANGELOG.asciidoc (elastic#1929)
  fixed community label action
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release v1.25.0
  Prepare release 1.25.0 (elastic#1927)
  synchronize json schema specs (elastic#1926)
  added labeling of community issues and PRs
  added community labeler config
  ...
@v1v
Enable weekly windows builds within the same default pipeline
cc5dce4
@v1v
Refactor
323b21d
@v1v
Use verify
c762000
@v1v
use the weekly one
ed90c1c
@v1v
Copy link
Member Author

v1v commented Aug 2, 2021

@SylvainJuge , this should answer your need to run for windows on a weekly basis that you asked for in:

@SylvainJuge
Copy link
Member

SylvainJuge commented Aug 2, 2021

Thanks @v1v , that was exactly the PR I was thinking about :-).

@v1v v1v requested review from SylvainJuge and eyalkoren August 2, 2021 13:56
@v1v
Copy link
Member Author

v1v commented Aug 2, 2021

@elastic/apm-agent-java , can we merge this?

@v1v
Copy link
Member Author

v1v commented Aug 2, 2021

/test

@SylvainJuge SylvainJuge mentioned this pull request Aug 20, 2021
Merged
@cachedout
Copy link
Contributor

cachedout commented Sep 23, 2021

@eyalkoren I think this is related to https://github.com/elastic/observability-robots/issues/443 and we may be waiting for a review here. Would you mind taking a look and letting us know if we have a 👍 to merge? Thanks!

@felixbarny
Merge branch 'master' into feature/pipeline-for-windows-only
1ed3a85
@felixbarny
Use test instead of verify
a855963 
The test goal doesn't require a Docker setup.
Verify executes the Docker-based integration tests.
Executing those on Windows doesn't add more coverage
and complicates the worker configuration.
@felixbarny
Copy link
Member

felixbarny commented Jan 18, 2022

I have changed the goal to use mvnw test instead of mvnw verify as the test goal doesn't require a Docker setup.
That should unblock this PR.

@felixbarny
Copy link
Member

felixbarny commented Jan 18, 2022

run windows tests

v1v
v1v commented Jan 20, 2022
View reviewed changes
@v1v v1v mentioned this pull request Jan 31, 2022
Merged
@SylvainJuge SylvainJuge merged commit 4a4eab6 into elastic:main Jan 31, 2022
@ghost
Copy link

ghost commented Jan 31, 2022

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Reason: null

  • Start Time: 2022-01-31T13:31:47.361+0000

  • Duration: 52 min 40 sec

  • Commit: f3742ea

Test stats 🧪

Test Results
Failed 0
Passed 2470
Skipped 16
Total 2486

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cachedout cachedout cachedout approved these changes

@SylvainJuge SylvainJuge SylvainJuge approved these changes

@kuisathaverat kuisathaverat kuisathaverat approved these changes

@eyalkoren eyalkoren Awaiting requested review from eyalkoren

Assignees

@v1v v1v

Labels

agent-java automation Tests & automation that help build & maintain the project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@v1v @SylvainJuge @cachedout @felixbarny @kuisathaverat @eyalkoren