Skip to content
This repository was archived by the owner on Oct 28, 2024. It is now read-only.

Conversation

@v1v
Copy link
Member

@v1v v1v commented Jan 31, 2022

What does this PR do?

Enable new GitHub command support for the APM Agent Java.

Why is it important?

Caused by elastic/apm-agent-java#1705

@v1v v1v requested a review from SylvainJuge January 31, 2022 13:52
@v1v v1v requested review from a team as code owners January 31, 2022 13:52
@botelastic botelastic bot added the groovy label Jan 31, 2022
@v1v v1v added ready-to-merge and removed groovy labels Jan 31, 2022
@mergify mergify bot assigned v1v Jan 31, 2022
@ghost
Copy link

ghost commented Jan 31, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Reason: null

  • Start Time: 2022-01-31T13:52:47.823+0000

  • Duration: 10 min 47 sec

  • Commit: 4657fd8

Test stats 🧪

Test Results
Failed 0
Passed 1335
Skipped 2
Total 1337

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run infra tests : Run the test-infra test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@SylvainJuge SylvainJuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Do you think there could be a way to directly define those once in each agent repo ? For example directly into the pipeline or close to where the trigger regex is being defined ?

@botelastic botelastic bot added the groovy label Jan 31, 2022
@v1v
Copy link
Member Author

v1v commented Jan 31, 2022

Do you think there could be a way to directly define those once in each agent repo ? For example directly into the pipeline or close to where the trigger regex is being defined ?

I've not found a way to define them and add some description easily. Maybe as you said, a file in the repository could be the one to be read and sent over, we can iterate on this idea, if the file is defined then it's read, though it makes the step to rely on the workspace to be able to read the file.

@mergify mergify bot merged commit cbf03f6 into elastic:main Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants