Skip to content

feat: use metricbeat to grab host metrics #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2021
Merged

feat: use metricbeat to grab host metrics #1718

merged 2 commits into from
Mar 30, 2021

Conversation

@kuisathaverat
Copy link
Contributor

@kuisathaverat kuisathaverat commented Mar 29, 2021 •
edited by zube bot
Loading

What does this PR do?

It uses a new pipeline step to report host metrics using Metricbeat to our load-test ESS cluster. This helps to analyze the test results and the host metrics.

@kuisathaverat kuisathaverat added automation Tests & automation that help build & maintain the project enhancement Enhancement of an existing feature labels Mar 29, 2021
@kuisathaverat kuisathaverat requested review from a team and SylvainJuge March 29, 2021 11:20
@kuisathaverat kuisathaverat self-assigned this Mar 29, 2021
@SylvainJuge
Copy link
Member

SylvainJuge commented Mar 29, 2021

Thanks for working on this.

Where does the metrics are being sent ? Are they pushed to the same cluster we use for running the APM server that we use to send metrics to ? Having everything in the same place would allow to check everything worked as expected (which was part of the initial request).

@ghost
Copy link

ghost commented Mar 29, 2021 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Branch indexing

  • Start Time: 2021-03-30T06:39:19.258+0000

  • Duration: 55 min 3 sec

  • Commit: ea0dc7a

Test stats 🧪

Test Results
Failed 0
Passed 1912
Skipped 19
Total 1931

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1912
Skipped 19
Total 1931

@kuisathaverat
Copy link
Contributor Author

kuisathaverat commented Mar 29, 2021

Thanks for working on this.

Where does the metrics are being sent ? Are they pushed to the same cluster we use for running the APM server that we use to send metrics to ? Having everything in the same place would allow to check everything worked as expected (which was part of the initial request).

The metrics will send to the same cluster and accessible by checking the metrics plugins, so I think we can correlate the traces and the metrics. Probably we have to make some tunning on ECS values, we will see it after a few executions.

@SylvainJuge SylvainJuge merged commit 65791ab into elastic:master Mar 30, 2021
@ghost
Copy link

ghost commented Mar 30, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1718 updated

  • Start Time: 2021-03-30T08:20:26.787+0000

  • Duration: 50 min 16 sec

  • Commit: 7b9eceb

Test stats 🧪

Test Results
Failed 0
Passed 1912
Skipped 19
Total 1931

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1912
Skipped 19
Total 1931

v1v added a commit to v1v/apm-agent-java that referenced this pull request Apr 7, 2021
@v1v
Merge branch 'feature/java-stable-tag' of github.com:v1v/apm-agent-ja…
af224b9 
…va into feature/java-stable-tag

* 'feature/java-stable-tag' of github.com:v1v/apm-agent-java: (534 commits)
  Added Support for JBoss Logging to the log correlation plugin (elastic#1737)
  Removing improper RabbitMQ reference from instrumentation class (elastic#1745)
  Loading Advice classes lazily when required (elastic#1736)
  add support for ibm JVMs (elastic#1739)
  Adds circuit breaker to app deployment in load pipeline (elastic#1731)
  Bump json-schema-validator from 1.0.50 to 1.0.51 (elastic#1732)
  Bump java-driver-core from 4.10.0 to 4.11.0 (elastic#1733)
  Cassandra instrumentation (elastic#1712)
  Build apm-agent-attach-cli before application-server-integration-tests (elastic#1729)
  Fix thread pool method matchers (elastic#1717)
  Always use English locale when formatting doubles (elastic#1727) (elastic#1728)
  feat: grab locust metrics on load tests (elastic#1724)
  log readonly msg errors only in debug (elastic#1715)
  feat: use metricbeat to grab host metrics (elastic#1718)
  Eliminate log4j shaders dependency in slf4j (elastic#1723)
  Fix log correlation for log4j2 (elastic#1720)
  Allowing more time for the test
  Bump json-schema-validator from 1.0.49 to 1.0.50 (elastic#1711)
  Fix master build and print URL on connection error
  Attacher improvements (elastic#1667)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cachedout cachedout cachedout approved these changes

@SylvainJuge SylvainJuge SylvainJuge approved these changes

@v1v v1v v1v approved these changes

+1 more reviewer

@mdelapenya mdelapenya mdelapenya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kuisathaverat kuisathaverat

Labels

agent-java automation Tests & automation that help build & maintain the project enhancement Enhancement of an existing feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kuisathaverat @SylvainJuge @cachedout @mdelapenya @v1v