Skip to content

Conversation

@felixbarny
Copy link
Member

@felixbarny felixbarny commented Aug 27, 2018

see #178

@felixbarny
Copy link
Member Author

Here is a snapshot build for this fix: elastic-apm-agent-0.7.0-SNAPSHOT.jar.zip

@codecov-io
Copy link

codecov-io commented Aug 27, 2018

Codecov Report

Merging #180 into master will decrease coverage by 0.04%.
The diff coverage is 70.37%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #180      +/-   ##
============================================
- Coverage     72.62%   72.58%   -0.05%     
- Complexity     1055     1059       +4     
============================================
  Files           118      118              
  Lines          4081     4096      +15     
  Branches        391      394       +3     
============================================
+ Hits           2964     2973       +9     
- Misses          930      933       +3     
- Partials        187      190       +3
Impacted Files Coverage Δ Complexity Δ
...ain/java/co/elastic/apm/impl/transaction/Span.java 93.75% <100%> (-0.13%) 19 <0> (ø)
.../co/elastic/apm/impl/transaction/AbstractSpan.java 71.64% <100%> (+0.42%) 21 <0> (ø) ⬇️
.../java/co/elastic/apm/report/ApmServerReporter.java 55.05% <50%> (-0.12%) 11 <1> (ø)
...ain/java/co/elastic/apm/impl/ElasticApmTracer.java 73.1% <58.33%> (-2.81%) 41 <2> (+1)
...stic/apm/objectpool/impl/QueueBasedObjectPool.java 36.36% <66.66%> (+3.03%) 7 <2> (+1) ⬆️
...a/co/elastic/apm/impl/transaction/Transaction.java 78.75% <83.33%> (+0.54%) 24 <3> (+1) ⬆️
...stic/apm/report/IntakeV1ReportingEventHandler.java 77.77% <0%> (+4.44%) 13% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1016a2...a1934cf. Read the comment docs.

@felixbarny
Copy link
Member Author

@Aketzu could you give this snapshot another try? elastic-apm-agent-0.7.0-SNAPSHOT.jar.zip

Maybe the AtomicReferenceArray in Java 1.7 contains a bug which leads to this situation.

@felixbarny
Copy link
Member Author

Corresponding snapshot: elastic-apm-agent-0.7.0-SNAPSHOT.jar.zip

@felixbarny felixbarny self-assigned this Aug 30, 2018
@felixbarny
Copy link
Member Author

Current snapshot: elastic-apm-agent-0.7.0-SNAPSHOT.jar.zip

@felixbarny
Copy link
Member Author

superseded by #205

@felixbarny felixbarny closed this Sep 17, 2018
@felixbarny felixbarny deleted the 178-mitigations branch September 17, 2018 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants