Use stable branch for release #2123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stable branch gets updated only when all the stages in the master build were successfully executed
v1v
commented
Sep 14, 2021
Comment on lines
+89
to
+92
| allOf { | ||
| expression { params.check_branch_ci_status } | ||
| not { branch 'stable' } | ||
| } |
Member
Author
There was a problem hiding this comment.
There is no need to validate the stable. Besides, stable builds don't exist as a Jenkins Multibranch Pipeline since they are filtered in
v1v
changed the title
eyalkoren
approved these changes
Sep 14, 2021
Member
Author
|
I'll merge this PR now since the CI doesn't validate these changes anyway. Linting ran correctly locally and the release will let us know if it worked as expected. |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use stable branch for the release. Stable branch gets updated automatically as part of the master build and only when the master build passed correctly.
Therefore, there is no need to validate if the tests failed for the stable branch since it should not happen at all.
Issues
Stable branch implementation was done in #1747 and #1771