Support older ES client versions #268
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new module is called 5.6 because it depends on the 5.6 version. I chose this version because it is the first ES client version that has both low-level and high-level client APIs and I wanted to test against those. However, as far as I can tell, this code supports all versions since 5.0.2.
Also, it should be safe for all versions continuously, meaning that for each version from 5.0.2 and to current only a single instrumentation is applied and only the right one.
NOTE: I tested everything with current ES version, assuming that as long as the client works well on it, it doesn't matter. Let me know if you think this is a wrong assumption
fixes #267