Skip to content

Conversation

@eyalkoren
Copy link
Contributor

@eyalkoren eyalkoren commented Oct 30, 2018

The new module is called 5.6 because it depends on the 5.6 version. I chose this version because it is the first ES client version that has both low-level and high-level client APIs and I wanted to test against those. However, as far as I can tell, this code supports all versions since 5.0.2.
Also, it should be safe for all versions continuously, meaning that for each version from 5.0.2 and to current only a single instrumentation is applied and only the right one.

NOTE: I tested everything with current ES version, assuming that as long as the client works well on it, it doesn't matter. Let me know if you think this is a wrong assumption

fixes #267

@codecov-io
Copy link

codecov-io commented Oct 30, 2018

Codecov Report

Merging #268 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #268   +/-   ##
=========================================
  Coverage     73.29%   73.29%           
  Complexity     1158     1158           
=========================================
  Files           124      124           
  Lines          4322     4322           
  Branches        431      431           
=========================================
  Hits           3168     3168           
  Misses          947      947           
  Partials        207      207
Impacted Files Coverage Δ Complexity Δ
...lastic/apm/plugin/api/ApiScopeInstrumentation.java 71.42% <ø> (ø) 5 <0> (ø) ⬇️
...a/co/elastic/apm/report/ReporterConfiguration.java 100% <0%> (ø) 11% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a15f2c6...c33e493. Read the comment docs.

@eyalkoren eyalkoren force-pushed the support-older-elasticsearch-client-versions branch from 32588cd to c33e493 Compare November 4, 2018 11:18
@eyalkoren eyalkoren merged commit 32a3642 into elastic:master Nov 4, 2018
@eyalkoren eyalkoren deleted the support-older-elasticsearch-client-versions branch January 9, 2019 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support older Elasticsearch Rest Client versions

3 participants