Skip to content

Conversation

@felixbarny
Copy link
Member

@felixbarny felixbarny commented Jul 6, 2022

Also fixes Javadoc task

What does this PR do?

The latest release of Vert.x 4.3.2 broke our build. The Javadoc task fails because io.vertx.core.impl.ContextImpl has been renamed to io.vertx.core.impl.ContextBase.
A couple of thoughts to make things more resilient:

  • We shouldn’t use version ranges, such as <version.vertx>[4.0.0,)</version.vertx>. Instead, use the latest version and rely on dependabot to update the version. This way, our existing test won’t break and we’ll still get notified when a new release of a library breaks our instrumentation.
  • When instrumenting internal classes, we should make sure to make the instrumentation less dependent on exact class names. For example, instead of a type matcher like named("io.vertx.core.impl.ContextImpl"), use nameStartsWith("io.vertx.core.impl.").and(hasSuperType(named("io.vertx.core.impl.ContextInternal")))

return named("io.vertx.core.impl.ContextImpl")
.and(not(isInterface()));

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation
  • This is a bugfix
  • This is a new plugin
    • I have updated CHANGELOG.asciidoc
    • My code follows the style guidelines of this project
    • I have made corresponding changes to the documentation
    • I have added tests that prove my fix is effective or that my feature works
    • New and existing unit tests pass locally with my changes
    • I have updated supported-technologies.asciidoc
    • Added an API method or config option? Document in which version this will be introduced
    • Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident.
  • This is something else

Also fixes Javadoc task
@felixbarny felixbarny enabled auto-merge (squash) July 6, 2022 14:32
@ghost
Copy link

ghost commented Jul 6, 2022

❕ Build Aborted

Either there was a build timeout or someone aborted the build.

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-06T21:50:56.042+0000

  • Duration: 93 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 2669
Skipped 25
Total 2694

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@felixbarny
Copy link
Member Author

/test

@felixbarny
Copy link
Member Author

This doesn't fix all test failures, yet and the build stalls.

@felixbarny felixbarny closed this Jul 7, 2022
auto-merge was automatically disabled July 7, 2022 06:17

Pull request was closed

@felixbarny felixbarny mentioned this pull request Jul 7, 2022
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants