-
Notifications
You must be signed in to change notification settings - Fork 327
Issue/272 change apmserver check from okHttp to URLConnection #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… okHttpClient in apm-servlet-plugin tests to HttpUrlConnection
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
Hi @nugusbayevkk, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile? |
felixbarny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR :)
Some notes:
- There is a strange
JulBridgeLogger.java_406862764079074file which should be deleted - It's ok for the tests to use OkHttp, please revert the test changes as it's simpler to write the tests using OkHttp :)
apm-agent-core/src/main/java/co/elastic/apm/report/ApmServerHealthChecker.java
Outdated
Show resolved
Hide resolved
apm-agent-core/src/main/java/co/elastic/apm/report/ApmServerHealthChecker.java
Outdated
Show resolved
Hide resolved
apm-agent-core/src/main/java/co/elastic/apm/report/HttpUtils.java
Outdated
Show resolved
Hide resolved
...-plugins/apm-api-plugin/src/main/java/co/elastic/apm/plugin/api/ApiScopeInstrumentation.java
Outdated
Show resolved
Hide resolved
|
Also remove the |
felixbarny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor thing, probably a leftover from testing. Other than that, LGTM :)
|
Jenkins test this please |
apm-agent-core/src/main/java/co/elastic/apm/report/ApmServerHealthChecker.java
Outdated
Show resolved
Hide resolved
Co-Authored-By: nugusbayevkk <kanagat.nugusbayev@gmail.com>
closes #272