Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Nov 3, 2018

closes #272

@elasticmachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ghost
Copy link

ghost commented Nov 3, 2018

Hi @nugusbayevkk, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

Copy link
Member

@felixbarny felixbarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR :)

Some notes:

  • There is a strange JulBridgeLogger.java_406862764079074 file which should be deleted
  • It's ok for the tests to use OkHttp, please revert the test changes as it's simpler to write the tests using OkHttp :)

@felixbarny
Copy link
Member

Also remove the okhttp and okio relocation patterns in elastic-apm-agent/pom.xml

Copy link
Member

@felixbarny felixbarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor thing, probably a leftover from testing. Other than that, LGTM :)

@felixbarny
Copy link
Member

Jenkins test this please

Co-Authored-By: nugusbayevkk <kanagat.nugusbayev@gmail.com>
@felixbarny felixbarny merged commit 38eebc5 into elastic:master Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use UrlConnection for APM Server health check and remove OkHttp dependency

3 participants