Skip to content

Conversation

@JonasKunz
Copy link
Contributor

@JonasKunz JonasKunz commented Apr 18, 2023

What does this PR do?

Part of #2942 .

  • Adds the missing tests for webflux with spring 6
  • Upgrades the webclient project to spring 6, added integration test to still also test with spring 5
  • Simplified dependency management: We only use now the spring-boot dependency management, which should simplify dependabot upgrades and avoid incompatibilities between dependencies

I won't update the changelog for this PR, as it only adds testing.

Checklist

@JonasKunz JonasKunz added the ci:jdk-compatibility Enables JDK compatibility tests in build pipeline label Apr 18, 2023
@ghost
Copy link

ghost commented Apr 18, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-04-27T14:39:18.322+0000

  • Duration: 15 min 10 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@JonasKunz JonasKunz requested a review from a team April 18, 2023 09:41
Copy link
Contributor

@jackshirazi jackshirazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice clean code!

@JonasKunz JonasKunz merged commit 729372b into elastic:main Apr 28, 2023
@JonasKunz JonasKunz deleted the spring6-webflux-tests branch April 28, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-java ci:jdk-compatibility Enables JDK compatibility tests in build pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants