-
Notifications
You must be signed in to change notification settings - Fork 327
Support async OkHttp calls #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
============================================
+ Coverage 64.19% 65.25% +1.06%
Complexity 68 68
============================================
Files 173 180 +7
Lines 6466 7438 +972
Branches 746 950 +204
============================================
+ Hits 4151 4854 +703
- Misses 2063 2323 +260
- Partials 252 261 +9
Continue to review full report at Codecov.
|
eyalkoren
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason I made most comments on the version 2 instrumentation, but they apply to both
...khttp-plugin/src/main/java/co/elastic/apm/agent/okhttp/OkHttpClientAsyncInstrumentation.java
Outdated
Show resolved
Hide resolved
...khttp-plugin/src/main/java/co/elastic/apm/agent/okhttp/OkHttpClientAsyncInstrumentation.java
Show resolved
Hide resolved
...khttp-plugin/src/main/java/co/elastic/apm/agent/okhttp/OkHttpClientAsyncInstrumentation.java
Show resolved
Hide resolved
...http-plugin/src/main/java/co/elastic/apm/agent/okhttp/OkHttp3ClientAsyncInstrumentation.java
Show resolved
Hide resolved
|
Jenkins run the tests |
closes #425