Skip to content

Conversation

@eyalkoren
Copy link
Contributor

@eyalkoren eyalkoren commented Mar 26, 2019

No description provided.

@eyalkoren eyalkoren requested a review from felixbarny March 26, 2019 08:50
Copy link
Member

@felixbarny felixbarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add "Align default transaction name to ' unknown route' (#542)". Maybe even to potentially breaking changes.

@codecov-io
Copy link

Codecov Report

Merging #546 into master will decrease coverage by 2.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             master   #546      +/-   ##
==========================================
- Coverage     65.21%    63%   -2.21%     
  Complexity       68     68              
==========================================
  Files           180    180              
  Lines          7189   6796     -393     
  Branches        860    776      -84     
==========================================
- Hits           4688   4282     -406     
- Misses         2252   2256       +4     
- Partials        249    258       +9
Impacted Files Coverage Δ Complexity Δ
.../apm/agent/report/serialize/DslJsonSerializer.java 81.84% <0%> (-6.41%) 0% <0%> (ø)
...pm/agent/report/IntakeV2ReportingEventHandler.java 76.23% <0%> (-5.15%) 0% <0%> (ø)
...tic/apm/agent/configuration/CoreConfiguration.java 95.94% <0%> (-2.25%) 0% <0%> (ø)
...a/co/elastic/apm/agent/report/ReporterFactory.java 78.26% <0%> (-0.91%) 0% <0%> (ø)
.../main/java/co/elastic/apm/agent/impl/MetaData.java 100% <0%> (ø) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ee68e3...f7819bd. Read the comment docs.

felixbarny and others added 2 commits March 26, 2019 11:11
Co-Authored-By: eyalkoren <41850454+eyalkoren@users.noreply.github.com>
@eyalkoren eyalkoren merged commit 84b3166 into master Mar 26, 2019
@eyalkoren eyalkoren deleted the update-changelog branch March 26, 2019 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants