Add feature flag for remote config #739
Conversation
| logger.info("Received new configuration from APM Server: <empty>"); | ||
| } | ||
| config = Collections.emptyMap(); | ||
| configurationRegistry.reloadDynamicConfigurationOptions(); |
There was a problem hiding this comment.
Does this means a user can't cancel configuration (ie restore defaults) by just removing it, and is instead required to actively set everything to specified values?
There was a problem hiding this comment.
Not sure I completely understand. The user can delete the central configuration in Kibana. The APM Server would then respond with a status code 200 and a {} body. That basically sets the config map to an empty map.
There was a problem hiding this comment.
The comment says:
// means that there either is no configuration for this agent or...
Sorry, I don't remember the spec, but I read that as getting 404 in such case
There was a problem hiding this comment.
The spec has recently been changed. The APM Server will now only return with 404 if it's pre 7.3: elastic/apm#118
There was a problem hiding this comment.
removed the outdated comment
Codecov Report
@@ Coverage Diff @@
## master #739 +/- ##
============================================
+ Coverage 64.79% 65.07% +0.28%
+ Complexity 169 68 -101
============================================
Files 209 209
Lines 8925 9006 +81
Branches 1147 1161 +14
============================================
+ Hits 5783 5861 +78
- Misses 2788 2791 +3
Partials 354 354
Continue to review full report at Codecov.
|
felixbarny
force-pushed
the
remote-config-feature-flag
branch
2 times, most recently
from
bc76da2 to
c449c98
Compare
Update 404 handling
felixbarny
force-pushed
the
remote-config-feature-flag
branch
from
c449c98 to
34795d1
Compare
4 participants
Update 404 handling