Skip to content

Conversation

@felixbarny
Copy link
Member

@felixbarny felixbarny commented Jul 26, 2019

closes #701

@codecov-io
Copy link

codecov-io commented Jul 26, 2019

Codecov Report

Merging #750 into master will decrease coverage by 0.47%.
The diff coverage is 77.08%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #750      +/-   ##
============================================
- Coverage     64.89%   64.41%   -0.48%     
  Complexity       68       68              
============================================
  Files           210      210              
  Lines          8955     8821     -134     
  Branches       1157     1117      -40     
============================================
- Hits           5811     5682     -129     
- Misses         2784     2788       +4     
+ Partials        360      351       -9
Impacted Files Coverage Δ Complexity Δ
...apm/agent/impl/transaction/TraceContextHolder.java 53.19% <0%> (-5.15%) 0 <0> (ø)
...pentracing/impl/ApmSpanBuilderInstrumentation.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...lastic/apm/agent/impl/transaction/Transaction.java 84.42% <100%> (-0.28%) 0 <0> (ø)
...nt/configuration/ApmServerConfigurationSource.java 78.4% <100%> (-0.48%) 0 <0> (ø)
...lastic/apm/agent/logging/LoggingConfiguration.java 92.3% <100%> (+0.74%) 0 <0> (ø) ⬇️
...va/co/elastic/apm/agent/impl/ElasticApmTracer.java 74.05% <100%> (-1.7%) 0 <0> (ø)
...tic/apm/agent/configuration/CoreConfiguration.java 90.63% <72.72%> (-7.1%) 0 <0> (ø)
...astic/apm/agent/impl/transaction/TraceContext.java 89.28% <78.57%> (-1.14%) 0 <0> (ø)
...ic/apm/agent/slf4j/Slf4JMdcActivationListener.java 86.04% <83.33%> (-2.85%) 0 <0> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 113167e...56901d4. Read the comment docs.

@felixbarny felixbarny changed the title Add config_file_location option Add config_file option Jul 26, 2019
Co-Authored-By: eyalkoren <41850454+eyalkoren@users.noreply.github.com>
@felixbarny felixbarny merged commit 6bdd74e into elastic:master Jul 29, 2019
@felixbarny felixbarny deleted the elasticapm-properties-location branch July 29, 2019 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add config for elasticapm.properties location

4 participants