Fix python-memcached package name #1001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
❕ Flaky test reportNo test was executed to be analysed. |
I think that the package name should be used instead of the library (or referenced alongside) for clarity.
angelakis
force-pushed
the
fix-python-memached-docs
branch
from
ed0f98d to
9495d72
Compare
basepi
approved these changes
Jan 11, 2021
Contributor
|
Thanks for this! |
beniwohli
pushed a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 14, 2021
I think that the package name should be used instead of the library (or referenced alongside) for clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
This PR makes a small change in python-memacached library name.
I think that the package name should be used instead of the imported library name for clarity (or at least referenced alongside).
Until I looked at the code, I thought that python-memcached was not supported based on the documentation, so hopefully this may save a little time for someone.