Skip to content

updated django versions in test requirements #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

updated django versions in test requirements #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/requirements/requirements-django-1.11.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Django>=1.11b1,<1.12
Django>=1.11,<2.0
Copy link
Contributor

@simitt simitt Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to have a 1.11 file that installs Django <2.0 ?

Copy link
Contributor Author

@beniwohli beniwohli Dec 4, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There never will be a Django 1.12, so <2.0 is equivalent to <1.12, but makes more sense with regards to the Django version history

-r requirements-base.txt
2 changes: 1 addition & 1 deletion tests/requirements/requirements-django-2.0.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Django>=2.0a1,<2.1
Django>=2.0,<2.1
-r requirements-base.txt