Validate every event created by the elasticapm_client test client #1091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, only when using sending_elasticapm_client, events were validated. This made us miss things like elastic#1088 and elastic#1089. With this change, every single event is validated against the apm-server JSONSchema.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
beniwohli
added a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 14, 2021
…astic#1091) * Validate every event created by the elasticapm_client test client So far, only when using sending_elasticapm_client, events were validated. This made us miss things like elastic#1088 and elastic#1089. With this change, every single event is validated against the apm-server JSONSchema. * fix encoding error in tornado revealed by validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, only when using sending_elasticapm_client, events were validated.
This made us miss things like #1088 and #1089. With this change,
every single event is validated against the apm-server JSONSchema.