Skip to content

Conversation

@basepi
Copy link
Contributor

@basepi basepi commented Jul 12, 2021

What does this pull request do?

The obvious next step when looking at manual instrumentation is propagating TraceParent for distributed tracing. Although we have some public API functions that help this, I figured it would be good to distill it down with some examples in our custom code documentation.

@basepi basepi self-assigned this Jul 12, 2021
@ghost
Copy link

ghost commented Jul 12, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-07-13T14:35:00.968+0000

  • Duration: 3 min 28 sec

  • Commit: fd1dfc8

Trends 🧪

Image of Build Times

❕ Flaky test report

No test was executed to be analysed.

@basepi basepi marked this pull request as ready for review July 12, 2021 17:14
@basepi basepi requested a review from beniwohli July 12, 2021 17:15
Copy link
Contributor

@beniwohli beniwohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, LGTM!

@basepi basepi merged commit b73fa71 into elastic:master Jul 13, 2021
beniwohli pushed a commit to beniwohli/apm-agent-python that referenced this pull request Sep 14, 2021
* Add docs for manual distributed tracing

* Use the public API call for getting the traceparent string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants