fetch server version on transport thread start #1194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will allow putting new features behind version guards, e.g. only sending histogram metrics to server versions that understand it
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
basepi
approved these changes
Jul 16, 2021
this allows us to set the server version in test fixtures. Without this, a lot of tests would need to be updated with updated request counts etc.
This has the effect that even old versions of APM Server reply with a flat JSON map, instead of nesting it under an "ok" key. Tested with APM Server 6.5
beniwohli
added a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 14, 2021
* fetch server version on transport thread start this will allow putting new features behind version guards, e.g. only sending histogram metrics to server versions that understand it * add option to set server version explicitly on client init this allows us to set the server version in test fixtures. Without this, a lot of tests would need to be updated with updated request counts etc. * use Accept: text/plain for server info endpoint This has the effect that even old versions of APM Server reply with a flat JSON map, instead of nesting it under an "ok" key. Tested with APM Server 6.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
this will allow putting new features behind version guards, e.g.
only sending histogram metrics to server versions that understand
it