added .hound.yml and updated config
#155
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beniwohli
force-pushed
the
hound-integration
branch
from
dae8836 to
3246995
Compare
houndci-bot
reviewed
Feb 12, 2018
elasticapm/base.py
Outdated
| import time | ||
| import zlib | ||
| from copy import deepcopy | ||
| import multiprocessing |
There was a problem hiding this comment.
'multiprocessing' imported but unused
elasticapm/__init__.py
Outdated
| set_transaction_name, set_user_context, tag) | ||
| from elasticapm.conf import setup_logging # noqa: F401 | ||
| from elasticapm.instrumentation.control import instrument, uninstrument # noqa: F401 | ||
| from elasticapm.traces import capture_span, set_context, set_custom_context, set_transaction_name, set_user_context, tag # noqa: F401 E501 |
There was a problem hiding this comment.
line too long (139 > 120 characters)
There was a problem hiding this comment.
IIRC, we have a limit of 140 chars
There was a problem hiding this comment.
Nope, in the Python agent, it's 120
Line 35 in 593e1c7
However, I added a # noqa E501 there to ignore this specific violation, guess houndci doesn't get that
beniwohli
force-pushed
the
hound-integration
branch
from
3246995 to
5a2f6f6
Compare
beniwohli
added a commit
that referenced
this pull request
Feb 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.